Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(tracking_object_merger)!: fix namespace and directory structure #7663

Conversation

technolojin
Copy link
Contributor

@technolojin technolojin commented Jun 24, 2024

Description

This PR puts headers in the autoware namespace.
Part of: autowarefoundation/autoware#4569

Additional works

  1. Align directory structure to follow the coding guidelines.
  2. Clean unused dependencies LIST

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Interface changes

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Jun 24, 2024
@technolojin technolojin added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jun 25, 2024
Copy link

codecov bot commented Jun 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (507e3f4) to head (4509c2f).
Report is 168 commits behind head on main.

Files Patch % Lines
...ject_merger/src/decorative_tracker_merger_node.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #7663       +/-   ##
==========================================
- Coverage   14.84%   0.00%   -14.85%     
==========================================
  Files        1999      65     -1934     
  Lines      139163    3699   -135464     
  Branches    43716     322    -43394     
==========================================
- Hits        20661       0    -20661     
+ Misses      95731    3699    -92032     
+ Partials    22771       0    -22771     
Flag Coverage Δ
differential 0.00% <0.00%> (?)
total ?

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@technolojin technolojin changed the title refactor(tracking_object_merger): namespace fix refactor(tracking_object_merger)!: fix namespace and directory structure Jun 25, 2024
Copy link

github-actions bot commented Jun 25, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

Copy link
Contributor

@YoshiRi YoshiRi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

technolojin and others added 8 commits June 27, 2024 15:48
)

* feat: separate filters

Signed-off-by: Taekjin LEE <[email protected]>

* fix: object validator to modular

Signed-off-by: Taekjin LEE <[email protected]>

* fix: replace xyzrpy covariance index

Signed-off-by: Taekjin LEE <[email protected]>

* chore: refactor tracker class members

Signed-off-by: Taekjin LEE <[email protected]>

* chore: refactor

Signed-off-by: Taekjin LEE <[email protected]>

* chore: refactoring destructor

Signed-off-by: Taekjin LEE <[email protected]>

* chore: refactoring getUpdatingObject

Signed-off-by: Taekjin LEE <[email protected]>

* chore: refactoring object size checker

Signed-off-by: Taekjin LEE <[email protected]>

* fix: debugger delay calculation order is fixed

Signed-off-by: Taekjin LEE <[email protected]>

* fix: bicycle size update bug fix

Signed-off-by: Taekjin LEE <[email protected]>

* fix: renamed message package

Signed-off-by: Taekjin LEE <[email protected]>

* chore: refactoring

Signed-off-by: Taekjin LEE <[email protected]>

* feat: object parameter class

Signed-off-by: Taekjin LEE <[email protected]>

* style(pre-commit): autofix

Signed-off-by: Taekjin LEE <[email protected]>

* chore: refactor includes

Signed-off-by: Taekjin LEE <[email protected]>

* feat: initial impl. of object model

Signed-off-by: Taekjin LEE <[email protected]>

* feat: impl. object model to bicycle, big, normal

Signed-off-by: Taekjin LEE <[email protected]>

* feat: impl. object model to pedestrian

Signed-off-by: Taekjin LEE <[email protected]>

* feat: impl. cont

Signed-off-by: Taekjin LEE <[email protected]>

* style(pre-commit): autofix

Signed-off-by: Taekjin LEE <[email protected]>

* chore: fix missing refactoring

Signed-off-by: Taekjin LEE <[email protected]>

* fix: align unit of angles, yaw rates

Signed-off-by: Taekjin LEE <[email protected]>

* fix: rename tier4_autoware_utils to autoware_universe_utils

Signed-off-by: Taekjin LEE <[email protected]>

* fix: missing unit conversion

Signed-off-by: Taekjin LEE <[email protected]>

* style(pre-commit): autofix

Signed-off-by: Taekjin LEE <[email protected]>

* fix: sources

Signed-off-by: Taekjin LEE <[email protected]>

* chore: Update include and import statements

Signed-off-by: Taekjin LEE <[email protected]>

* fix: unit convert bug

Signed-off-by: Taekjin LEE <[email protected]>

* fix: update to autoware::universe_utils

Signed-off-by: Taekjin LEE <[email protected]>

* fix: mis-implementation of process noise

Signed-off-by: Taekjin LEE <[email protected]>

---------

Signed-off-by: Taekjin LEE <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: Taekjin LEE <[email protected]>
@technolojin technolojin force-pushed the refactor/namespace-tracking_object_merger branch from 2858871 to fb9cc44 Compare June 27, 2024 06:49
@technolojin technolojin merged commit cfcf1e7 into autowarefoundation:main Jun 27, 2024
28 of 31 checks passed
mitukou1109 pushed a commit to mitukou1109/autoware.universe that referenced this pull request Jul 2, 2024
…ure (autowarefoundation#7663)

* chore: refactor file paths in tracking_object_merger module

Signed-off-by: Taekjin LEE <[email protected]>

* chore: refactor file paths in tracking_object_merger module

Signed-off-by: Taekjin LEE <[email protected]>

* chore: refactor include statement in decorative_tracker_merger.hpp

Signed-off-by: Taekjin LEE <[email protected]>

* chore: refactor include statement in decorative_tracker_merger.hpp

Signed-off-by: Taekjin LEE <[email protected]

* chore: refactor association file path in tracking_object_merger module

Signed-off-by: Taekjin LEE <[email protected]>

* refactor: update include statements in tracking_object_merger module

Signed-off-by: Taekjin LEE <[email protected]>

* refactor: move the node header to src

Signed-off-by: Taekjin LEE <[email protected]>

---------

Signed-off-by: Taekjin LEE <[email protected]>
Signed-off-by: Taekjin LEE <[email protected]
palas21 pushed a commit to palas21/autoware.universe that referenced this pull request Jul 12, 2024
…ure (autowarefoundation#7663)

* chore: refactor file paths in tracking_object_merger module

Signed-off-by: Taekjin LEE <[email protected]>

* chore: refactor file paths in tracking_object_merger module

Signed-off-by: Taekjin LEE <[email protected]>

* chore: refactor include statement in decorative_tracker_merger.hpp

Signed-off-by: Taekjin LEE <[email protected]>

* chore: refactor include statement in decorative_tracker_merger.hpp

Signed-off-by: Taekjin LEE <[email protected]

* chore: refactor association file path in tracking_object_merger module

Signed-off-by: Taekjin LEE <[email protected]>

* refactor: update include statements in tracking_object_merger module

Signed-off-by: Taekjin LEE <[email protected]>

* refactor: move the node header to src

Signed-off-by: Taekjin LEE <[email protected]>

---------

Signed-off-by: Taekjin LEE <[email protected]>
Signed-off-by: Taekjin LEE <[email protected]
Signed-off-by: palas21 <[email protected]>
tby-udel pushed a commit to tby-udel/autoware.universe that referenced this pull request Jul 14, 2024
…ure (autowarefoundation#7663)

* chore: refactor file paths in tracking_object_merger module

Signed-off-by: Taekjin LEE <[email protected]>

* chore: refactor file paths in tracking_object_merger module

Signed-off-by: Taekjin LEE <[email protected]>

* chore: refactor include statement in decorative_tracker_merger.hpp

Signed-off-by: Taekjin LEE <[email protected]>

* chore: refactor include statement in decorative_tracker_merger.hpp

Signed-off-by: Taekjin LEE <[email protected]

* chore: refactor association file path in tracking_object_merger module

Signed-off-by: Taekjin LEE <[email protected]>

* refactor: update include statements in tracking_object_merger module

Signed-off-by: Taekjin LEE <[email protected]>

* refactor: move the node header to src

Signed-off-by: Taekjin LEE <[email protected]>

---------

Signed-off-by: Taekjin LEE <[email protected]>
Signed-off-by: Taekjin LEE <[email protected]
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
…ure (#7663)

* chore: refactor file paths in tracking_object_merger module

Signed-off-by: Taekjin LEE <[email protected]>

* chore: refactor file paths in tracking_object_merger module

Signed-off-by: Taekjin LEE <[email protected]>

* chore: refactor include statement in decorative_tracker_merger.hpp

Signed-off-by: Taekjin LEE <[email protected]>

* chore: refactor include statement in decorative_tracker_merger.hpp

Signed-off-by: Taekjin LEE <[email protected]

* chore: refactor association file path in tracking_object_merger module

Signed-off-by: Taekjin LEE <[email protected]>

* refactor: update include statements in tracking_object_merger module

Signed-off-by: Taekjin LEE <[email protected]>

* refactor: move the node header to src

Signed-off-by: Taekjin LEE <[email protected]>

---------

Signed-off-by: Taekjin LEE <[email protected]>
Signed-off-by: Taekjin LEE <[email protected]
@technolojin technolojin deleted the refactor/namespace-tracking_object_merger branch July 26, 2024 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants